Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #756

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Solution #756

wants to merge 4 commits into from

Conversation

A-n-a-s-t-a-s-i-i-a
Copy link

No description provided.

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Dec 10, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task! 🎉 Your code meets all the specified requirements and follows Django best practices. While the ALLOWED_HOSTS list is empty, which is important for production security, it doesn't impact the core functionality of your code. Keep up the excellent work, and consider updating ALLOWED_HOSTS for a secure deployment. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

cinema_service/settings.py

# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = True
DEBUG = False

ALLOWED_HOSTS = []
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ALLOWED_HOSTS list is currently empty. For production, you should specify the domain names or IP addresses that are allowed to serve the application to prevent HTTP Host header attacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A-n-a-s-t-a-s-i-i-a @mateacademy-ai-mentor